-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure multinode clusters can survive restarts #7973
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #7973 +/- ##
==========================================
- Coverage 34.60% 34.51% -0.09%
==========================================
Files 147 147
Lines 9378 9401 +23
==========================================
Hits 3245 3245
- Misses 5736 5757 +21
- Partials 397 399 +2
|
/ok-to-test |
kvm2 Driver |
kvm2 Driver Times for Minikube (PR 7973): [65.484962536 66.415054937 64.840697597] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [24.235588917 26.600426017 24.261345107999997] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 7973): [65.22296300699999 65.79751244799999 65.75328363500002] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [30.159359658 27.129887715000002 28.234326952] Averages Time Per Log
|
on kvm I see this error:
so it seems like is failing because one of the node's kubelet is "stopped" the question is, is that a normal thing ? is that okay for a node's kubelet to be stopped ? secondly we need to add this to all the subtests, so we could have seen the logs for the kublet
so please add this so we know why it failed |
kvm2 Driver Times for Minikube (PR 7973): [66.440837307 65.258476876 66.138815794] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [26.781780021 27.878319794 28.062798046999998] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 7973): [64.470353064 63.528211406 66.112156886] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [26.455807898000003 28.316644833 26.156449873] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 7973): [66.80655133799999 64.81349420400001 63.33818678499999] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [27.084916353 26.40355993 25.450216769999997] Averages Time Per Log
|
Travis tests have failedHey @sharifelgamal, 1st Buildmake test
TravisBuddy Request Identifier: c8e27860-9bc1-11ea-9438-0b74518d636c |
kvm2 Driver Times for Minikube (PR 7973): [63.565084184 64.37706506 61.454181332999994] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [27.939966897 25.753531435 26.397611032999997] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 7973): [67.83212226299999 64.745072134 60.655826620999996] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [27.507146273 29.135927897 26.893359191] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 7973): [63.127890451 63.711317521 62.37630870900001] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [26.913629169 25.327199245000003 27.182615238] Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 7973): [63.55283334000001 65.123136077 61.765616205] Averages Time Per Log
docker Driver Times for Minikube (PR 7973): [27.081522105 27.790656118999998 27.011139165] Averages Time Per Log
|
Fixes #7496